Added mpl_15 decorator #18682
Merged
Added mpl_15 decorator #18682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18682 +/- ##
==========================================
- Coverage 91.59% 91.57% -0.02%
==========================================
Files 153 153
Lines 51257 51266 +9
==========================================
Hits 46949 46949
- Misses 4308 4317 +9
Continue to review full report at Codecov.
|
jreback
added
Testing
jreback
approved these changes
Dec 8, 2017
| @@ -519,14 +519,14 @@ def test_finder_hourly(self): | |||
| xp = Period('1/1/1999', freq='H').ordinal | |||
| assert rs == xp | |||
|
|
|||
| @td.skip_if_mpl_1_5 | |||
| @pytest.mark.slow | |||
| def test_gaps(self): | |||
| ts = tm.makeTimeSeries() | |||
| ts[5:25] = np.nan | |||
| _, ax = self.plt.subplots() | |||
| ts.plot(ax=ax) | |||
| lines = ax.get_lines() | |||
There was a problem hiding this comment.
yeah, we occasionally do this. if its actually important then could split into 2 tests. not a big deal here.
|
thanks! |
16 tasks
This was referenced Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffFWIW the functionality here could be slightly different, because the previous skip if items occurred in the middle of the function bodies instead of wrapping the function, so the first few lines of code within those functions would run in instances that are being skipped today.
I've ignored that nuance because I find it strange that we would only want to run part of the test without any assertions for different versions of matplotlib, but if you feel it needs to be accounted for in some other fashion (say separate test cases) let me know